[FC-0036] feat: Send messages after update tags #975
Conversation
* One message with new content tags * One message with the tag count
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 703 703
Lines 12334 12334
Branches 2671 2667 -4
=======================================
Hits 11372 11372
Misses 926 926
Partials 36 36 ☔ View full report in Codecov by Sentry. |
ChrisChV
changed the title
There was a problem hiding this comment.
👍 @ChrisChV Looks good!
- I tested this: I followed the testing instructions [FC-0036] fix: Update tag counts when changes are saved in the tag drawer edx-platform#34682
- I read through the code
- I checked for accessibility issues
-
Includes documentation
@xitij2000 Yes, I have not do a test for this task because it is temporary and urgent. It's ready to merge |
|
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Updates the code of Tag Drawer to send two messages to parent (if the drawer is a iframe) when the tags are updated:
Supporting information
Testing instructions